[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for... | linux-arm-kernel

[PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return(). · Chen Gang <hidden> · 2013-09-21
[PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return(). · Will Deacon <hidden> · 2013-09-24
[PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return(). · Russell King - ARM Linux <hidden> · 2013-09-24
[PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return(). · Chen Gang <hidden> · 2013-09-24
[PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return(). · Chen Gang <hidden> · 2013-09-24
[PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Chen Gang <hidden> · 2013-09-25
[PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Will Deacon <hidden> · 2013-09-25
[PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Chen Gang <hidden> · 2013-09-26
[PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Will Deacon <hidden> · 2013-09-26
[PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Chen Gang <hidden> · 2013-09-26
[PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Will Deacon <hidden> · 2013-09-27
[PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Chen Gang <hidden> · 2013-09-27
[PATCH 0/2] ARM: include: asm: change functions' and variables' types in atomic.h · Chen Gang <hidden> · 2013-09-29
[PATCH 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Chen Gang <hidden> · 2013-09-29
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-09-29
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-09-30
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-01
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-01
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-01
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-02
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-02
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-03
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-03
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-04
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-04
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-04
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-04
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-05
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-08
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-08
[PATCH v2 0/2] ARM: include: asm: change functions' and variables' types in atomic.h · Chen Gang <hidden> · 2013-10-08
[PATCH v2 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Chen Gang <hidden> · 2013-10-08
[PATCH v2 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for 'oldval' in atomic_cmpxchg(). · Chen Gang <hidden> · 2013-10-08
[PATCH v2 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for 'oldval' in atomic_cmpxchg(). · Will Deacon <hidden> · 2013-10-09
[PATCH v2 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for 'oldval' in atomic_cmpxchg(). · Chen Gang <hidden> · 2013-10-10
[PATCH v2 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Will Deacon <hidden> · 2013-10-09
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-08
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-08
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-08
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Will Deacon <hidden> · 2013-10-08
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-09
[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h · Chen Gang <hidden> · 2013-10-09
[PATCH 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Will Deacon <hidden> · 2013-09-30
[PATCH 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h · Chen Gang <hidden> · 2013-10-01

STALE4633d

[PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables within atomic.h

From: Will Deacon <hidden>
Date: 2013-09-30 16:11:49

On Sun, Sep 29, 2013 at 04:52:28AM +0100, Chen Gang wrote:

"arc/arm" will be never on 64-bit, it is mainly on 32-bit (may also can
be on 16-bit).

So better to use 'int' instead of 'unsigned long' for normal register
variable (on 16-bit, 'int' is allowed to be 16-bit, so historically,
often use 'int' for normal register variables).

This commit message doesn't make a blind bit of sense! arch/arm/ is a 32-bit
architecture in the sense that int will always be 32-bit there. This patch
is just a cosmetic change, bringing our atomic_t manipulation code inline
with the atomic_t type definition.

quoted hunk ↗ jump to hunk

@@ -297,7 +297,7 @@ static inline void atomic64_set(atomic64_t *v, long

long i)
 static inline void atomic64_add(long long i, atomic64_t *v)
 {
 	long long result;
-	unsigned long tmp;
+	int tmp;

Please leave the atomic64_* functions alone here; the reasoning I explained
above doesn't apply to them. Whilst int may work, it seems gratuitous to
make this change for no reason.

Will

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help