[PATCH v5 1/3] clk: samsung: Add clock driver for s5pc110/s5pv210
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
Date: 2013-09-24 13:58:15
Also in:
linux-devicetree, linux-pm, linux-samsung-soc, lkml
Hi, On 24/09/13 14:50, Mateusz Krawczuk wrote:
quoted hunk ↗ jump to hunk
+++ b/Documentation/devicetree/bindings/clock/samsung,s5pv210-clock.txt@@ -0,0 +1,75 @@ +* Samsung S5PC110/S5PV210 Clock Controller + +The S5PV210 clock controller generates and supplies clock to various controllers +within the SoC. The clock binding described here is applicable to all SoCs in +the S5PC110/S5PV210 family. + +Required Properties: + +- compatible: should be "samsung,s5pv210-clock".
I have nothing against this compatible value, but wouldn't it be more accurate to use, e.g. "samsung,s5pv210-cmu" - for Clock Management Unit, as this IP block is also referred to in the documentation ? May just be me, but "samsung,s5pv210-clock" sounds like just one specific clock type. -- Thanks, Sylwester