[PATCH 38/38] iio: magn-core: st: Provide support for the LSM303DLH

On Mon, 16 Sep 2013, Denis CIOCCA wrote:

Hi Lee,

quoted

index 12e7e79..b2e2917 100644

--- a/drivers/iio/magnetometer/st_magn_core.c
+++ b/drivers/iio/magnetometer/st_magn_core.c

@@ -151,7 +151,8 @@ static const struct st_sensors st_magn_sensors[] = {
  		.wai = ST_MAGN_1_WAI_EXP,
  		.sensors_supported = {
  			[0] = LSM303DLHC_MAGN_DEV_NAME,
-			[1] = LSM303DLM_MAGN_DEV_NAME,
+			[1] = LSM303DLH_MAGN_DEV_NAME,
+			[0] = LSM303DLM_MAGN_DEV_NAME,

Are you sure that it works?

Well I have tested it working.

Because LSM303DLH magnetometer use different kind of WAI registers. This 
driver read 0x0f and in this case the value is 0 and the driver do not 
probe...You have to read the identification registers (0x0a, 0x0b, 0x0c) 
in that case.

The driver mentions that the first group of sensors have a WAI of 0x3c:

  #define ST_MAGN_1_WAI_EXP    0x3c

And when I print out the WAI read from the device: 
  
  Requested device: lsm303dlh_magn - read WAI: 0x3c

I guess I could have been lied to again by the board's datasheet again
and the attached device isn't actually a LSM303DLH, but how can I tell
for sure?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog