Thread (105 messages) flat view 105 messages, 8 authors, 2013-09-17

[PATCH 27/38] iio: pressure-core: st: Give some indication if device probing was successful

From: jic23@kernel.org (Jonathan Cameron)
Date: 2013-09-10 16:25:43
Also in: linux-iio, lkml


Lee Jones [off-list ref] wrote:
quoted hunk ↗ jump to hunk
At the moment the driver is silent in some error cases and if
successful.
Prior to this patch there was no clear way to know if the driver
succeeded
or not without looking deep into sysfs.

Signed-off-by: Lee Jones <redacted>
---
drivers/iio/pressure/st_pressure_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iio/pressure/st_pressure_core.c
b/drivers/iio/pressure/st_pressure_core.c
index 6ffd949..34b3fb1 100644
--- a/drivers/iio/pressure/st_pressure_core.c
+++ b/drivers/iio/pressure/st_pressure_core.c
@@ -280,6 +280,9 @@ int st_press_common_probe(struct iio_dev
*indio_dev,
	if (err && irq > 0)
		goto st_press_device_register_error;

+	if (!err)
+		dev_info(&indio_dev->dev, "Successfully registered\n");
+
Not keen. That to my mind is pointless noise. If this made sense then it would be in the driver core not here.
	return err;

st_press_device_register_error:
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help