[PATCH v4 2/3] ARM: bcm281xx: Enable GPIO driver
From: Linus Walleij <hidden>
Date: 2013-08-23 17:37:22
On Mon, Aug 19, 2013 at 8:59 PM, Markus Mayer [off-list ref] wrote:
This patch adds the Kconfig and Makefile glue to compile the GPIO driver for bcm281xx when CONFIG_GPIO_BCM=y. Signed-off-by: Markus Mayer <redacted> Reviewed-by: Tim Kryger <redacted> Reviewed-by: Matt Porter <redacted>
(...)
quoted hunk ↗ jump to hunk
+++ b/arch/arm/mach-bcm/Kconfig@@ -9,7 +9,6 @@ config ARCH_BCM select CLKSRC_OF select GENERIC_CLOCKEVENTS select GENERIC_TIME - select GPIO_BCM
select GPIO_BCM_KONA
quoted hunk ↗ jump to hunk
select SPARSE_IRQ select TICK_ONESHOT helpdiff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index b2450ba..869e234 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig@@ -714,6 +714,13 @@ config GPIO_MSIC Enable support for GPIO on intel MSIC controllers found in intel MID devices +config GPIO_BCM_KONA + bool "Broadcom Kona GPIO" + depends on ARCH_BCM + default y
I prefer that you do not depend on ARCH_BCM and do not encode default y, but select it in the arch instead. That way some other system can test-compile it for example. Which should work fine. And when that can be done, some of the good kernel proofreaders and janitors will make a deep review some day. Yours, Linus Walleij