Thread (11 messages) flat view 11 messages, 2 authors, 2013-08-19
STALE4769d

[PATCH v4 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev()

From: Sergei Shtylyov <hidden>
Date: 2013-08-19 14:23:37
Also in: linux-omap

Hello.

On 08/19/2013 02:37 PM, Roger Quadros wrote:
omap_get_control_dev() is being deprecated as it doesn't support
multiple instances. As control device is present only from OMAP4
onwards which supports DT only, we use phandles to get the
reference to the control device.
As we don't support non-DT boot, we just bail out on probe
if device node is not present.
Signed-off-by: Roger Quadros <redacted>
---
  drivers/usb/phy/phy-omap-usb3.c |   22 ++++++++++++++++++----
  1 files changed, 18 insertions(+), 4 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/usb/phy/phy-omap-usb3.c b/drivers/usb/phy/phy-omap-usb3.c
index 4a7f27c..981313e 100644
--- a/drivers/usb/phy/phy-omap-usb3.c
+++ b/drivers/usb/phy/phy-omap-usb3.c
[...]
quoted hunk ↗ jump to hunk
@@ -198,6 +199,12 @@ static int omap_usb3_probe(struct platform_device *pdev)
  {
  	struct omap_usb			*phy;
  	struct resource			*res;
+	struct device_node *node = pdev->dev.of_node;
+	struct device_node *control_node;
+	struct platform_device *control_pdev;
    Could you align the variable names with the above 2 variables?
Either that, or remove the alignment of those two.

WBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help