[PATCH v4 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev()

Hi Sergei,

On 08/19/2013 05:23 PM, Sergei Shtylyov wrote:

Hello.

On 08/19/2013 02:37 PM, Roger Quadros wrote:

quoted

omap_get_control_dev() is being deprecated as it doesn't support
multiple instances. As control device is present only from OMAP4
onwards which supports DT only, we use phandles to get the
reference to the control device.

quoted

As we don't support non-DT boot, we just bail out on probe
if device node is not present.

quoted

Signed-off-by: Roger Quadros <redacted>
---
  drivers/usb/phy/phy-omap-usb3.c |   22 ++++++++++++++++++----
  1 files changed, 18 insertions(+), 4 deletions(-)

quoted

diff --git a/drivers/usb/phy/phy-omap-usb3.c b/drivers/usb/phy/phy-omap-usb3.c
index 4a7f27c..981313e 100644
--- a/drivers/usb/phy/phy-omap-usb3.c
+++ b/drivers/usb/phy/phy-omap-usb3.c

[...]

quoted

@@ -198,6 +199,12 @@ static int omap_usb3_probe(struct platform_device *pdev)
  {
      struct omap_usb            *phy;
      struct resource            *res;
+    struct device_node *node = pdev->dev.of_node;
+    struct device_node *control_node;
+    struct platform_device *control_pdev;

   Could you align the variable names with the above 2 variables?
Either that, or remove the alignment of those two.

OK, I'll remove the alignment of the 1st two lines.

cheers,
-roger