On 07/29/2013 05:24 AM, Mark Rutland wrote:

On Sun, Jul 28, 2013 at 10:56:38PM +0100, Rob Herring wrote:

quoted

From: Rob Herring <redacted>

Add the PSCI binding for Calxeda SOCs. The PSCI function numbers are
different from the DT binding example because the numbering changed in
revisions of the PSCI spec and are already fixed in highbank firmware.
Since the numbering is transparent to the kernel, this difference is not
significant.

Signed-off-by: Rob Herring <redacted>
---
 arch/arm/boot/dts/ecx-common.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/ecx-common.dtsi b/arch/arm/boot/dts/ecx-common.dtsi
index e8559b7..f1dfc09 100644
--- a/arch/arm/boot/dts/ecx-common.dtsi
+++ b/arch/arm/boot/dts/ecx-common.dtsi

@@ -19,6 +19,16 @@
 		bootargs = "console=ttyAMA0";
 	};
 
+	psci {
+		compatible	= "arm,psci";
+		method		= "smc";
+		cpu_suspend	= <0x84000002>;
+		cpu_off		= <0x84000004>;
+		cpu_on		= <0x84000006>;
+		system_off	= <0x84000100>;
+		system_reset	= <0x84000101>;
+	};
+

I see this is somewhat beyond the original PSCI, given the addition of
SYSTEM_OFF and SYSTEM_RESET, but not quite PSCI 0.2 as you don't have
PSCI_VERSION.

I do actually support PSCI_VERSION. Forgot to add that to the dts.

It would be nice it the compatible string were more specific here to
deal with this and any implementation-specific power_state ID values.
Something like "calxeda,highbank-psci", "arm,psci" ?

Is that something we always want to do? You can't really know the
implementation quirks up front.

Rob