[PATCH, RFC 14/22] oprofile: always enable IRQ_WORK

From
Steven Rostedt <rostedt@goodmis.org>
Date
2013-05-03 13:30:22
Also in
lkml
Reply to
Robert Richter, 2013-05-03
On Fri, 2013-05-03 at 13:53 +0200, Robert Richter wrote:
On 02.05.13 17:16:18, Arnd Bergmann wrote:
quoted
oprofile fails to build if CONFIG_IRQ_WORK is not already enabled,
because of the dependency on the RING_BUFFER code that now uses
the irq work library.

kernel/built-in.o: In function `ring_buffer_unlock_commit':
:(.text+0x5b8f0): undefined reference to `irq_work_queue'
kernel/built-in.o: In function `ring_buffer_write':
:(.text+0x5bd10): undefined reference to `irq_work_queue'
Shouldn't this be fixed in the ring_buffer implementation?
Hmm, I thought I had ring buffer select irq work. I must have not have
done that.
I also do not see, where this comes from. I was successfully compiling
a kernel with OPROFILE and RING_BUFFER enabled but IRQ_WORK disabled.
Do you have that config still available?
The ring buffer code can now wake up waiters, and to do so it requires
irq_work. I'll send a patch.

Thanks,

-- Steve
Thread (74 messages) 74 messages, 23 authors, last reply 2013-05-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help