[PATCH, RFC 15/22] USB: EHCI: remove bogus #error

From
Arnd Bergmann <arnd@arndb.de>
Date
2013-05-02 17:55:37
Also in
lkml
Reply to
Alan Stern, 2013-05-02
On Thursday 02 May 2013, Alan Stern wrote:
On Thu, 2 May 2013, Arnd Bergmann wrote:
quoted
The EHCI host controller driver can be built standalone now,
without enabling any of the available bus glue drivers, so
there is not really a reason to error out here:
On the other hand, there's no reason to build the driver without any 
bus glue.  It wouldn't do anything.
Yes, as I mention below, we could also use Kconfig logic to prevent
that case, as the OHCI and UHCI patches from this series do, but I felt
that would be a lot of unnecessary churn, and having just ehci-hci.ko
enabled without a bus glue is not an error, it's just as pointless
as most of the other drivers we get with "make randconfig".
quoted
drivers/usb/host/ehci-hcd.c:1303:2: error:
 #error "missing bus glue for ehci-hcd"  #error "missing bus glue for ehci-hcd"

The alternative would be to change the Kconfig code to build
the ehci-hcd module only if any of the symbols below are
in fact enabled.
	Arnd
Thread (74 messages) 74 messages, 23 authors, last reply 2013-05-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help