Thread (64 messages) 64 messages, 7 authors, 2013-04-23
STALE4812d

[PATCH 28/29] arm64: KVM: 32bit guest fault injection

From: Christopher Covington <hidden>
Date: 2013-03-18 18:45:42
Also in: kvm

Hi Marc,

Here are a few more preprocessor definition suggestions.

On 03/04/2013 10:47 PM, Marc Zyngier wrote:
quoted hunk ↗ jump to hunk
Add fault injection capability for 32bit guests.

Signed-off-by: Marc Zyngier <redacted>
---
 arch/arm64/kvm/inject_fault.c | 79 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 78 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/inject_fault.c b/arch/arm64/kvm/inject_fault.c
index 80b245f..85a4548 100644
--- a/arch/arm64/kvm/inject_fault.c
+++ b/arch/arm64/kvm/inject_fault.c
@@ -1,5 +1,5 @@
 /*
- * Fault injection for 64bit guests.
+ * Fault injection for both 32 and 64bit guests.
  *
  * Copyright (C) 2012 - ARM Ltd
  * Author: Marc Zyngier <marc.zyngier@arm.com>
@@ -24,6 +24,74 @@
 #include <linux/kvm_host.h>
 #include <asm/kvm_emulate.h>
 
+static void prepare_fault32(struct kvm_vcpu *vcpu, u32 mode, u32 vect_offset)
+{
+	unsigned long cpsr;
+	unsigned long new_spsr_value = *vcpu_cpsr(vcpu);
+	bool is_thumb = (new_spsr_value & COMPAT_PSR_T_BIT);
+	u32 return_offset = (is_thumb) ? 4 : 0;
+	u32 sctlr = vcpu->arch.cp15[c1_SCTLR];
+
+	cpsr = mode | COMPAT_PSR_I_BIT;
+
+	if (sctlr & (1 << 30))
COMPAT_SCTLR_TE?
+		cpsr |= COMPAT_PSR_T_BIT;
+	if (sctlr & (1 << 25))
SCTLR_EL2_EE
+		cpsr |= COMPAT_PSR_E_BIT;
+
+	*vcpu_cpsr(vcpu) = cpsr;
+
+	/* Note: These now point to the banked copies */
+	*vcpu_spsr(vcpu) = new_spsr_value;
+	*vcpu_reg(vcpu, 14) = *vcpu_pc(vcpu) + return_offset;
+
+	/* Branch to exception vector */
+	if (sctlr & (1 << 13))
COMPAT_SCTLR_V?
+		vect_offset += 0xffff0000;
+	else /* always have security exceptions */
+		vect_offset += vcpu->arch.cp15[c12_VBAR];
+
+	*vcpu_pc(vcpu) = vect_offset;
+}
+
+static void inject_undef32(struct kvm_vcpu *vcpu)
+{
+	prepare_fault32(vcpu, COMPAT_PSR_MODE_UND, 4);
+}
+
+/*
+ * Modelled after TakeDataAbortException() and TakePrefetchAbortException
+ * pseudocode.
+ */
+static void inject_abt32(struct kvm_vcpu *vcpu, bool is_pabt,
+			 unsigned long addr)
+{
+	u32 vect_offset;
+	u32 *far, *fsr;
+	bool is_lpae;
+
+	if (is_pabt) {
+		vect_offset = 12;
+		far = &vcpu->arch.cp15[c6_IFAR];
+		fsr = &vcpu->arch.cp15[c5_IFSR];
+	} else { /* !iabt */
+		vect_offset = 16;
+		far = &vcpu->arch.cp15[c6_DFAR];
+		fsr = &vcpu->arch.cp15[c5_DFSR];
+	}
+
+	prepare_fault32(vcpu, COMPAT_PSR_MODE_ABT | COMPAT_PSR_A_BIT, vect_offset);
+
+	*far = addr;
+
+	/* Always give debug fault for now - should give guest a clue */
+	is_lpae = (vcpu->arch.cp15[c2_TTBCR] >> 31);
COMPAT_TTBCR_EAE?
+	if (is_lpae)
+		*fsr = 1 << 9 | 0x22;
COMPAT_FSR_LPAE, COMPAT_FSR_LD_FS_DBG?
+	else
+		*fsr = 2;
COMPAT_FSR_SD_FS_DBG?

[...]

Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
the Linux Foundation
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help