Thread (64 messages) 64 messages, 7 authors, 2013-04-23
STALE4812d

[PATCH 23/29] arm64: KVM: 32bit GP register access

From: geoff@infradead.org (Geoff Levand)
Date: 2013-03-16 00:24:26
Also in: kvm

Hi Marc,

On Tue, 2013-03-05 at 03:47 +0000, Marc Zyngier wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/kvm/regmap.c b/arch/arm64/kvm/regmap.c
new file mode 100644
index 0000000..f8d4a0c
--- /dev/null
+++ b/arch/arm64/kvm/regmap.c
...
+	switch (mode) {
+	case COMPAT_PSR_MODE_USR...COMPAT_PSR_MODE_SVC:
I think it would be safer to have this with spaces in case someone
changes the macro defs or copies this to make some new code and screws
up their defs:

  case COMPAT_PSR_MODE_USR ... COMPAT_PSR_MODE_SVC:

See: http://gcc.gnu.org/onlinedocs/gcc-4.1.2/gcc/Case-Ranges.html

-Geoff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help