Thread (8 messages) 8 messages, 3 authors, 2013-01-31
DORMANTno replies

[PATCH v2] ARM: OMAP2: hwmod: Fix "register offset NULL check" bug

From: Hebbar, Gururaja <hidden>
Date: 2013-01-31 05:25:24
Also in: linux-omap

On Wed, Jan 30, 2013 at 22:09:51, Paul Walmsley wrote:
On Wed, 30 Jan 2013, Hebbar, Gururaja wrote:
quoted
On Thu, Dec 20, 2012 at 13:05:27, Paul Walmsley wrote:
quoted
On Thu, 20 Dec 2012, Hebbar, Gururaja wrote:
quoted
On Wed, Dec 19, 2012 at 07:43:50, Paul Walmsley wrote:
quoted
We've got a few hwmods on OMAP44xx that don't have clkctrl_offs registers 
listed in the hwmod data, and which are not marked with HWMOD_NO_IDLEST.  
What's going to happen in those cases?
Hmm. This is a special case to me. Let me go back and do some review.
Will be back with some more details.
Probably what needs to happen is that those hwmods need to be marked with 
HWMOD_NO_IDLEST, in a separate patch before yours.  As far as I can tell, 
that's how they should have been marked initially.  Then your patch should 
be fine.
Looking at latest kernel v3.8-rc5, there is separate cm33xx.c file which
handles module ready checking for am33xx platform. So I will update this 
patch to work on this file instead of touching omap4 related file 
(cminst44xx.c)
The same problem still exists.  According to the TRM, there's at least one
AM335x CLKCTRL register that doesn't have IDLEST bits.  So to avoid 
reading reserved bits, either this patch or a preceding patch should
mark those hwmods with HWMOD_NO_IDLEST.
Ok. I will look into this now.

- Paul

Regards, 
Gururaja
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help