Thread (8 messages) 8 messages, 3 authors, 2013-01-31
STALE4884d

[PATCH v2] ARM: OMAP2: hwmod: Fix "register offset NULL check" bug

From: paul@pwsan.com (Paul Walmsley)
Date: 2012-12-19 02:13:50
Also in: linux-omap

On Tue, 18 Dec 2012, Hebbar Gururaja wrote:
From: "Hebbar, Gururaja" <redacted>

omap4_cminst_wait_module_ready() checks if register offset is NULL.

int omap4_cminst_wait_module_ready(u8 part, u16 inst, s16 cdoffs,
				   u16 clkctrl_offs)
{
	int i = 0;

	if (!clkctrl_offs)
		return 0;

In case of AM33xx, CLKCTRL register offset for different clock domains
are not uniformly placed. An example of this would be the RTC clock
domain with CLKCTRL offset at 0x00.
In such cases the module ready check is skipped which leads to a data
abort during boot-up when RTC registers is accessed.
We've got a few hwmods on OMAP44xx that don't have clkctrl_offs registers 
listed in the hwmod data, and which are not marked with HWMOD_NO_IDLEST.  
What's going to happen in those cases?


- Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help