Thread (7 messages) flat view 7 messages, 4 authors, 2013-01-02
STALE4991d

[PATCH] ARM: tegra: cpufreq: move clk_get/put out of function tegra_cpu_init/exit

From: Peter De Schrijver <hidden>
Date: 2013-01-02 12:30:14
Also in: linux-tegra

On Fri, Dec 21, 2012 at 10:27:43PM +0100, Stephen Warren wrote:
On 12/21/2012 03:09 AM, Richard Zhao wrote:
quoted
tegra_cpu_init/exit will be called every time one cpu core is online or
offline. And all cpu cores share same clocks, redundant clk_get/put
wast time,  so I move them out.
I think this is reasonable.

Prashant, Peter, any comments?

Is any other work in tegra_cpu_init() redundant? Is tegra_cpu_init()
supposed to be called due to hotplug, or is that a bug in the cpufreq core?
I think we want to keep target_cpu_speed[] as a possible input for the
(to be upstreamed) cluster switching logic. Yes, tegra_cpu_init() should be
called due to hotplug. Some systems might need specific initialization for
cpufreq when a new CPU comes online. Also the available frequencies might
be different per CPU. So this information needs to be provided for each
CPU.

Cheers,

Peter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help