Thread (76 messages) 76 messages, 18 authors, 2013-02-14

[PATCH 05/15] ASoC: fsl: fiq and dma cannot both be modules

From: Shawn Guo <hidden>
Date: 2013-01-22 03:22:01
Also in: alsa-devel, lkml

On Mon, Jan 21, 2013 at 05:15:58PM +0000, Arnd Bergmann wrote:
The dma and fiq portions of the imx-pcm driver both
have a module_init() call, of which there can be only
one in any given module. This changes Kconfig to enforce
either the driver to be built-in in the kernel, or
to have only one of the two when building imx-pcm as
a module.

Without this patch, we cannot build the ARM 'allmodconfig', or
we get this error:

sound/soc/fsl/imx-pcm-dma.o: In function `init_module':
sound/soc/fsl/imx-pcm-dma.c:177: multiple definition of `init_module'
sound/soc/fsl/imx-pcm-fiq.o:sound/soc/fsl/imx-pcm-fiq.c:334: first defined here
sound/soc/fsl/imx-pcm-dma.o: In function `cleanup_module':
sound/soc/fsl/imx-pcm-dma.c:177: multiple definition of `cleanup_module'
sound/soc/fsl/imx-pcm-fiq.o:sound/soc/fsl/imx-pcm-fiq.c:334: first defined here

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Liam Girdwood <redacted>
Cc: Mark Brown <redacted>
Cc: Shawn Guo <redacted>
Cc: alsa-devel at alsa-project.org
I sent a fix [1] for that queued by Mark.

Mark,

Is the patch on the way to 3.8-rc?

Shawn

[1] http://thread.gmane.org/gmane.linux.alsa.devel/104434
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help