[PATCH 15/15] staging/omapdrm: don't build on multiplatform
From: arnd@arndb.de (Arnd Bergmann)
Date: 2013-01-21 17:41:22
Also in:
lkml
On Monday 21 January 2013, Rob Clark wrote:
Are you sure OMAP2_DSS requires ARCH_OMAP2PLUS? I don't see this, and it at least used to not depend on ARCH_OMAP2PLUS. If it does now, I think the correct fix would be to remove the dependency in OMAP2_DSS. I don't think removing ARCH_MULTIPLATFORM support in omapdrm is the correct solution.
At least it says so in drivers/video/omap2/Kconfig, which contains if ARCH_OMAP2PLUS source drivers/video/omap2/dss/Kconfig endif We can probably change this, but until we do, we should not select OMAP2_DSS from something that doesn't also depend on ARCH_OMAP2PLUS.
quoted
drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div': drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier is reported only once for each function it appears in drivers/staging/omapdrm/omap_connector.c: In function 'omap_connector_dpms': drivers/staging/omapdrm/omap_connector.c:116:8: error: 'OMAP_DSS_DISPLAY_SUSPENDED' undeclared (first use in this function) drivers/staging/omapdrm/omap_connector.c:116:8: note: each undeclared identifier is reported only once for each function it appears inThis was an unrelated build break which should be fixed in latest master after 'staging: drm/omap: use omapdss low level API'
Ok, it seems the message is stale then, I created the patch some time ago, but only today wrote rest of the explanation for the changeset text. With all the other patches from my series applied, allyesconfig still gives me drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared because that symbol is only defined when OMAP2_DSS is enabled rather than selected. Changing drivers/video/omap2/Kconfig to not depend on OMAP seems to work as well, but that seems a little intrusive for v3.8, because it would let a lot of people build that code that have no use for it. Arnd