[RFC v1 01/16] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT
From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-12-11 15:42:06
Also in:
lkml
On Friday 07 December 2012, Thomas Petazzoni wrote:
The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O ports.
I think this one is wrong as the CONFIG_HAS_IOPORT does not refer to the presence of PIO ports but to whether or not they provide an ioport_map function. If there is no ioport_map(), devm_pci_iomap will fail to link as far as I can tell. Arnd
quoted hunk ↗ jump to hunk
Signed-off-by: Thomas Petazzoni <redacted> Cc: Paul Gortmaker <redacted> Cc: Jesse Barnes <redacted> Cc: Yinghai Lu <yinghai@kernel.org> Cc: linux-kernel at vger.kernel.org --- lib/devres.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/lib/devres.c b/lib/devres.c index 80b9c76..5639c3e 100644 --- a/lib/devres.c +++ b/lib/devres.c@@ -195,6 +195,7 @@ void devm_ioport_unmap(struct device *dev, void __iomem *addr) devm_ioport_map_match, (void *)addr)); } EXPORT_SYMBOL(devm_ioport_unmap); +#endif /* CONFIG_HAS_IOPORT */ #ifdef CONFIG_PCI /*@@ -400,4 +401,3 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask) } EXPORT_SYMBOL(pcim_iounmap_regions); #endif /* CONFIG_PCI */ -#endif /* CONFIG_HAS_IOPORT */