Thread (16 messages) 16 messages, 4 authors, 2012-11-05
STALE4960d

[PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c

From: tony@atomide.com (Tony Lindgren)
Date: 2012-11-05 15:36:33
Also in: linux-omap

* Tomi Valkeinen [off-list ref] [121105 00:06]:
On 2012-11-02 20:54, Tony Lindgren wrote:
quoted
quoted
* Santosh Shilimkar [off-list ref] [121102 01:56]:
quoted
On Friday 02 November 2012 02:19 PM, Tomi Valkeinen wrote:
quoted
On 2012-11-02 08:38, Santosh Shilimkar wrote:
quoted
Lets not move this in DMA code since the above is really related
to frame buffer. It reserves more DMA area for dma_alloc_coherent()
etc than default 2 MB. Infact, we should no longer need this with
CMA and memblock in place.

Tomi,
Can we not get rid of the above memory reservation ?
Yes, I think so. This one is only used for the old omapfb, i.e. omap1,
and I have no means to test it out, though. But below is a patch to
remove it. I also attached the patch, as it looks like thunderbird wants
to reformat the pasted patch... I'll remove the
CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE from the omapfb driver's Kconfig file
in my tree later.
Hmm actually, is it safe to remove for omap1, or should we
still keep it around for omap1?
Why wouldn't it be safe? Do you mean that CMA doesn't work on omap1,
or...? I'm no expert on CMA, but as far as I can see with it's ARM
generic stuff.
Just wondering after your comment "This one is only used for the old
omapfb, i.e. omap1". But sounds like it should no longer be needed
there either if I parse that right.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help