Thread (16 messages) 16 messages, 4 authors, 2012-11-05
STALE4955d
Revisions (6)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 current
  5. v1 [diff vs current]
  6. v1 [diff vs current]

[PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c

From: Santosh Shilimkar <hidden>
Date: 2012-11-02 06:38:38
Also in: linux-omap

Tony,

On Friday 02 November 2012 04:18 AM, Tony Lindgren wrote:
This file has only omap_init_consistent_dma_size()
left that can be moved to plat-omap/dma.c.

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
  arch/arm/plat-omap/Makefile |    2 +-
  arch/arm/plat-omap/common.c |   26 --------------------------
  arch/arm/plat-omap/dma.c    |    8 ++++++++
  3 files changed, 9 insertions(+), 27 deletions(-)
  delete mode 100644 arch/arm/plat-omap/common.c
[..]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index c288b76..00a3a53 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -2146,6 +2146,14 @@ static struct platform_driver omap_system_dma_driver = {
  	},
  };

+/* This must be called from init_early() */
+void __init omap_init_consistent_dma_size(void)
+{
+#ifdef CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE
+	init_consistent_dma_size(CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE << 20);
+#endif
+}
+
Lets not move this in DMA code since the above is really related
to frame buffer. It reserves more DMA area for dma_alloc_coherent()
etc than default 2 MB. Infact, we should no longer need this with
CMA and memblock in place.

Tomi,
Can we not get rid of the above memory reservation ?

Regards
santosh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help