Thread (8 messages) 8 messages, 3 authors, 2012-11-05
STALE4969d

[PATCH] i2c: at91: add a sanity check on i2c message length

From: Wolfram Sang <hidden>
Date: 2012-11-03 14:16:24
Also in: linux-i2c

quoted
quoted
Yes SMBUS quick command is supported but is not managed in the
driver, we have to tell explicitly the IP that we want to send this
command.
Ok, so unless you want to implement the support, please update this
patch with a comment that SMBUS_QUICK is a TODO and remove the
SMBUS_QUICK capability.
Implementation should not be a huge task, only one bit to set in a
register but I have no device to test it.
'i2cdetect' from i2c-tools uses SMBUS_QUICK as one method to detect
chips. Most slaves (both I2C and SMBus) react to that, so that would do
in my book.
Did you test the driver with SMBus compatible devices? Can I keep
other SMBus capabilities from SMBUS_EMUL?
The rest should be fine.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121103/b3b8259b/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help