Thread (8 messages) 8 messages, 3 authors, 2012-11-05
STALE4976d

[PATCH] i2c: at91: add a sanity check on i2c message length

From: ludovic.desroches <hidden>
Date: 2012-11-02 11:04:45
Also in: linux-i2c

Hi Wolfram,

Le 11/01/2012 11:29 PM, Wolfram Sang a ?crit :
On Wed, Oct 10, 2012 at 04:25:58PM +0200, ludovic.desroches at atmel.com wrote:
quoted
From: Ludovic Desroches <redacted>

If the i2c message length is zero, i2c-at91 will directly return an error
instead of trying to send a zero-length message.

Signed-off-by: Ludovic Desroches <redacted>
What happens if you send a 0 byte message? Some hardware is able to do
this and it will be used in SMBUS QUICK which the driver states to
support according to at91_twi_func().
Without this I had some data corruption when writing to / reading from a 
serial eeprom (depending on the IP version).

Yes SMBUS quick command is supported but is not managed in the driver, 
we have to tell explicitly the IP that we want to send this command.


Regards

Ludovic
Regards,

    Wolfram
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help