Thread (41 messages) 41 messages, 6 authors, 2012-11-12

[PATCH 15/16] mm: use vm_unmapped_area() on sparc32 architecture

From: davem@davemloft.net (David Miller)
Date: 2012-11-06 17:41:39
Also in: linux-mips, linux-mm, linux-sh, lkml, sparclinux

From: Rik van Riel <redacted>
Date: Tue, 06 Nov 2012 02:30:07 -0500
On 11/05/2012 08:25 PM, David Miller wrote:
quoted
From: Michel Lespinasse <redacted>
Date: Mon,  5 Nov 2012 14:47:12 -0800
quoted
Update the sparc32 arch_get_unmapped_area function to make use of
vm_unmapped_area() instead of implementing a brute force search.

Signed-off-by: Michel Lespinasse <redacted>
Hmmm...
quoted
-	if (flags & MAP_SHARED)
-		addr = COLOUR_ALIGN(addr);
-	else
-		addr = PAGE_ALIGN(addr);
What part of vm_unmapped_area() is going to duplicate this special
aligning logic we need on sparc?
That would be this part:

+found:
+ /* We found a suitable gap. Clip it with the original low_limit. */
+	if (gap_start < info->low_limit)
+		gap_start = info->low_limit;
+
+	/* Adjust gap address to the desired alignment */
+ gap_start += (info->align_offset - gap_start) & info->align_mask;
+
+	VM_BUG_ON(gap_start + info->length > info->high_limit);
+	VM_BUG_ON(gap_start + info->length > gap_end);
+	return gap_start;
+}
Ok, now I understand.  Works for me:

Acked-by: David S. Miller <davem@davemloft.net>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help