Thread (41 messages) 41 messages, 6 authors, 2012-11-12

[PATCH 15/16] mm: use vm_unmapped_area() on sparc32 architecture

From: Michel Lespinasse <hidden>
Date: 2012-11-06 03:13:22
Also in: linux-mips, linux-mm, linux-sh, lkml, sparclinux

On Mon, Nov 5, 2012 at 5:25 PM, David Miller [off-list ref] wrote:
From: Michel Lespinasse <redacted>
Date: Mon,  5 Nov 2012 14:47:12 -0800
quoted
Update the sparc32 arch_get_unmapped_area function to make use of
vm_unmapped_area() instead of implementing a brute force search.

Signed-off-by: Michel Lespinasse <redacted>
Hmmm...
quoted
-     if (flags & MAP_SHARED)
-             addr = COLOUR_ALIGN(addr);
-     else
-             addr = PAGE_ALIGN(addr);
What part of vm_unmapped_area() is going to duplicate this special
aligning logic we need on sparc?
The idea there is that you can specify the desired alignment mask and
offset using info.align_mask and info.align_offset.

Now, I just noticed that the old code actually always uses an
alignment offset of 0 instead of basing it on pgoff. I'm not sure why
that is, but it looks like this may be an issue ?

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help