Thread (58 messages) 58 messages, 8 authors, 2012-11-07
STALE4957d
Revisions (5)
  1. v1 [diff vs current]
  2. v1 current
  3. v1 [diff vs current]
  4. v1 [diff vs current]
  5. v1 [diff vs current]

[PATCH 0/9] ARM: Kirkwood: Convert to pinctrl

From: Thomas Petazzoni <hidden>
Date: 2012-10-24 21:33:56

Andrew,

On Wed, 24 Oct 2012 22:01:28 +0200, Andrew Lunn wrote:
I guess it is too early to use gpio. I don't think the gpio driver has
not been configured yet.

I need to think about this.

What happens if you comment out these two gpio_set_value calls?
The problem is (probably, I haven't tested) that in
mach-kirkwood/board-dt.c, the of_platform_populate() function is called
after all the board-specific init. So all the devices described in the
DT, including GPIO banks, have not been registered yet. Most likely the
of_platform_populate() should come before the board specific inits.

Also there should probably  be a gpio_request() before those
gpio_set_value().

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help