On Tue, Oct 23, 2012 at 8:09 PM, Kevin Hilman
[off-list ref] wrote:
From: Kevin Hilman <redacted>
When debounce clocks are disabled, ensure that the banks
dbck_enable_mask is cleared also. Otherwise, context restore on
subsequent off-mode transition will restore previous value from the
shadow copies (bank->context.debounce*) leading to mismatch state
between driver state and hardware state.
This was discovered when board code was doing
gpio_request_one()
gpio_set_debounce()
gpio_free()
which was leaving the GPIO debounce settings in a confused state.
Then, enabling off mode causing bogus state to be restored, leaving
GPIO debounce enabled which then prevented the CORE powerdomain from
transitioning.
Reported-by: Paul Walmsley <paul@pwsan.com>
Cc: Igor Grinberg <redacted>
Signed-off-by: Kevin Hilman <redacted>
Thanks! Applied with Felipe's and Santosh's ACKs.
Yours,
Linus Walleij