Thread (8 messages) flat view 8 messages, 6 authors, 2012-10-24
STALE5060d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

From: Santosh Shilimkar <hidden>
Date: 2012-10-24 07:33:45
Also in: linux-omap

On Tuesday 23 October 2012 11:39 PM, Kevin Hilman wrote:
From: Kevin Hilman <redacted>

When debounce clocks are disabled, ensure that the banks
dbck_enable_mask is cleared also.  Otherwise, context restore on
subsequent off-mode transition will restore previous value from the
shadow copies (bank->context.debounce*) leading to mismatch state
between driver state and hardware state.

This was discovered when board code was doing

   gpio_request_one()
   gpio_set_debounce()
   gpio_free()

which was leaving the GPIO debounce settings in a confused state.
Then, enabling off mode causing bogus state to be restored, leaving
GPIO debounce enabled which then prevented the CORE powerdomain from
transitioning.

Reported-by: Paul Walmsley <paul@pwsan.com>
Cc: Igor Grinberg <redacted>
Signed-off-by: Kevin Hilman <redacted>
---
Acked-by: Santosh Shilimkar <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help