On 10/16/2012 16:49, Jean-Christophe PLAGNIOL-VILLARD wrote:

On 10:07 Tue 16 Oct     , Nicolas Ferre wrote:

quoted

On 10/16/2012 05:56 AM, Bo Shen :

quoted

This patch removes some code duplication by using module_platform_driver

Signed-off-by: Bo Shen <redacted>

Very good simplification but...

quoted

---
  drivers/misc/atmel-ssc.c |   18 ++++--------------
  1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index 23dcb76..ac00f83 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c

@@ -68,7 +68,7 @@ void ssc_free(struct ssc_device *ssc)
  }
  EXPORT_SYMBOL(ssc_free);

-static int __init ssc_probe(struct platform_device *pdev)
+static int ssc_probe(struct platform_device *pdev)

Here you remove the __init altogether, maybe converting to __devinit is
the proper replacement for this? I do not know myself but if anybody knows?

yes __devinit is mandatory

I will add a small patch to fix this.

Thanks.

BRs,
Bo Shen

Best Regards,
J.