Thread (9 messages) 9 messages, 6 authors, 2012-10-16
STALE5005d

[PATCH 2/2] ASoC: atmel-ssc: use module_platform_driver macro

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2012-10-16 08:49:47
Also in: alsa-devel, linux-sound

On 10:07 Tue 16 Oct     , Nicolas Ferre wrote:
On 10/16/2012 05:56 AM, Bo Shen :
quoted
This patch removes some code duplication by using module_platform_driver

Signed-off-by: Bo Shen <redacted>
Very good simplification but...
quoted
---
 drivers/misc/atmel-ssc.c |   18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index 23dcb76..ac00f83 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -68,7 +68,7 @@ void ssc_free(struct ssc_device *ssc)
 }
 EXPORT_SYMBOL(ssc_free);
 
-static int __init ssc_probe(struct platform_device *pdev)
+static int ssc_probe(struct platform_device *pdev)
Here you remove the __init altogether, maybe converting to __devinit is
the proper replacement for this? I do not know myself but if anybody knows?
yes __devinit is mandatory

Best Regards,
J.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help