Thread (8 messages) 8 messages, 3 authors, 2012-12-13
STALE4952d REVIEWED: 1 (0M)

[PATCH] mmc: mmci: Fixup and cleanup code for DMA handling

From: Linus Walleij <hidden>
Date: 2012-10-12 21:32:31
Also in: linux-mmc

On Fri, Oct 12, 2012 at 5:33 PM, Ulf Hansson [off-list ref] wrote:
From: Ulf Hansson <redacted>

The cookie is now used to indicate if dma_unmap_sg shall be
done in post_request. At DMA errors, the DMA job is immediately
not only terminated but also unmapped. To indicate that this
has been done the cookie is reset to zero. post_request will
thus only do dma_umap_sg for requests which has a cookie not set
to zero.

Some corresponding duplicated code could then be removed and
moreover some corrections at DMA errors for terminating the same
DMA job twice has also been fixed.

Signed-off-by: Ulf Hansson <redacted>
Signed-off-by: Per Forlin <redacted>
It looks like it's both factoring out code and also adding some unmapping
in hithereto unhandled cases, correct? It looks OK to me now atleast so
Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help