[PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

Hi Sylwester,

Thanks for the review.

On 17 October 2012 20:03, Sylwester Nawrocki [off-list ref] wrote:

Hi Sachin,

On 10/17/2012 01:11 PM, Sachin Kamat wrote:

quoted

Replace clk_enable/clk_disable with clk_prepare_enable/clk_disable_unprepare
as required by the common clock framework.

You need to be careful with those replacements, since the clk *_(un)prepare
functions may sleep, i.e. they must not be called from atomic context.

OK.

Most of the s5p-* drivers have already added support for clk_(un)prepare.
Thus most of your changes in this patch are not needed. I seem to have only
missed fimc-mdevice.c, other modules are already reworked

I did not find these changes in your tree. Please let me know the
branch where these changes are available.

$ git grep -5  clk_prepare  -- drivers/media/platform/s5p-fimc
drivers/media/platform/s5p-fimc/fimc-core.c-
drivers/media/platform/s5p-fimc/fimc-core.c-    for (i = 0; i < MAX_FIMC_CLOCKS; i++) {
drivers/media/platform/s5p-fimc/fimc-core.c-            fimc->clock[i] = clk_get(&fimc->pdev->dev, fimc_clocks[i]);
drivers/media/platform/s5p-fimc/fimc-core.c-            if (IS_ERR(fimc->clock[i]))

quoted

I would prefer you have added the required changes at fimc_md_get_clocks()

and fimc_md_put_clocks() functions.

Ok. I will check this.

-- 
With warm regards,
Sachin