[PATCH] media: fimc: check return value of clk_enable in runtime_resume" -m "In fimc_runtime_resume(), the return value of clk_enable(fimc->clock[CLK_GATE]) was not checked. If enabling the clock fails, subsequent register accesses (fimc_hw_reset() and capture/m2m resume) may trigger a bus error or undefined behavior.
From: Zhaoyang Yu <hidden>
Date: 2026-03-01 16:19:02
Also in:
linux-media, linux-samsung-soc, lkml
Subsystem:
media input infrastructure (v4l/dvb), samsung s5p/exynos4 soc series camera subsystem drivers, the rest · Maintainers:
Mauro Carvalho Chehab, Sylwester Nawrocki, Linus Torvalds
Fix this by checking the return value. If clk_enable() fails, return the error immediately, preventing unsafe hardware access. Signed-off-by: Zhaoyang Yu <redacted> --- drivers/media/platform/samsung/exynos4-is/fimc-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-core.c b/drivers/media/platform/samsung/exynos4-is/fimc-core.c
index 2c9edd0a559b..57e573949e54 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-core.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-core.c@@ -1020,11 +1020,15 @@ static int fimc_probe(struct platform_device *pdev) static int fimc_runtime_resume(struct device *dev) { struct fimc_dev *fimc = dev_get_drvdata(dev); + int ret; dbg("fimc%d: state: 0x%lx", fimc->id, fimc->state); /* Enable clocks and perform basic initialization */ - clk_enable(fimc->clock[CLK_GATE]); + ret = clk_enable(fimc->clock[CLK_GATE]); + if (ret) + return ret; + fimc_hw_reset(fimc); /* Resume the capture or mem-to-mem device */
--
2.34.1