[PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp

On Fri, Oct 26, 2012 at 10:21:41AM -0700, Tony Lindgren wrote:

* Arnd Bergmann [off-list ref] [121026 00:48]:

quoted

On Friday 26 October 2012, Felipe Balbi wrote:

quoted

quoted

+static void omap_init_ocp2scp(void)
+{
+     struct omap_hwmod       *oh;
+     struct platform_device  *pdev;
+     int                     bus_id = -1, dev_cnt = 0, i;
+     struct omap_ocp2scp_dev *ocp2scp_dev;
+     const char              *oh_name, *name;
+     struct omap_ocp2scp_platform_data *pdata;
+
+     oh_name = "ocp2scp_usb_phy";
+     name    = "omap-ocp2scp";

how about adding checks here to return early case we're not running on
OMAP4 or OMAP5 ??

I suppose even OMAP4-only, since OMAP5 always has DT enabled.

Hmm yes, currently omap_hwmod_lookup(oh_name) produces
bogus errors for other omaps as the hwmod data is only
there for omap4.

shouldn't that be fixed too ? I mean, if data isn't just return -ENODEV
or something similar.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121026/f7cbc29e/attachment.sig>