Thread (23 messages) flat view 23 messages, 4 authors, 2012-10-29

[PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp

From: tony@atomide.com (Tony Lindgren)
Date: 2012-10-26 17:21:52
Also in: linux-omap, lkml

* Arnd Bergmann [off-list ref] [121026 00:48]:
On Friday 26 October 2012, Felipe Balbi wrote:
quoted
quoted
+static void omap_init_ocp2scp(void)
+{
+     struct omap_hwmod       *oh;
+     struct platform_device  *pdev;
+     int                     bus_id = -1, dev_cnt = 0, i;
+     struct omap_ocp2scp_dev *ocp2scp_dev;
+     const char              *oh_name, *name;
+     struct omap_ocp2scp_platform_data *pdata;
+
+     oh_name = "ocp2scp_usb_phy";
+     name    = "omap-ocp2scp";
how about adding checks here to return early case we're not running on
OMAP4 or OMAP5 ??
I suppose even OMAP4-only, since OMAP5 always has DT enabled.
Hmm yes, currently omap_hwmod_lookup(oh_name) produces
bogus errors for other omaps as the hwmod data is only
there for omap4.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help