[PATCH] ARM: mx28: Skip OCOTP FEC MAC setup if in DT

Dear Shawn Guo,

On Tue, Sep 25, 2012 at 01:01:46PM +0200, Marek Vasut wrote:

quoted

quoted

quoted

 		np = of_find_compatible_node(from, NULL, "fsl,imx28-

fec");

quoted

quoted

quoted

 		if (!np)
 		
 			return;

+
+		if (of_get_property(np, "local-mac-address", NULL))
+			continue;
+

The block should be put after "from" assignment below.

Can you please elaborate why would that be necessary?

Without assigning 'np' to 'from', the next iteration of 'for' loop
will still find the first fec node.  Then what's point of 'continue'?

Ewww, you're right.

Shawn

Best regards,
Marek Vasut