Thread (5 messages) flat view 5 messages, 2 authors, 2012-09-25
STALE5061d

[PATCH] ARM: mx28: Skip OCOTP FEC MAC setup if in DT

From: Shawn Guo <hidden>
Date: 2012-09-25 11:24:33

On Tue, Sep 25, 2012 at 01:01:46PM +0200, Marek Vasut wrote:
quoted
quoted
 		np = of_find_compatible_node(from, NULL, "fsl,imx28-fec");
 		if (!np)
 		
 			return;

+
+		if (of_get_property(np, "local-mac-address", NULL))
+			continue;
+
The block should be put after "from" assignment below.
Can you please elaborate why would that be necessary?
Without assigning 'np' to 'from', the next iteration of 'for' loop
will still find the first fec node.  Then what's point of 'continue'?

Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help