Thread (69 messages) flat view 69 messages, 5 authors, 2012-09-25
STALE5087d REVIEWED: 3 (3M)

1 review trailer.

[PATCH v3 RESEND 06/17] ARM: LPAE: use signed arithmetic for mask definitions

From: catalin.marinas@arm.com (Catalin Marinas)
Date: 2012-09-24 13:09:51

On Fri, Sep 21, 2012 at 04:56:04PM +0100, Cyril Chemparathy wrote:
This patch applies to PAGE_MASK, PMD_MASK, and PGDIR_MASK, where forcing
unsigned long math truncates the mask at the 32-bits.  This clearly does bad
things on PAE systems.

This patch fixes this problem by defining these masks as signed quantities.
We then rely on sign extension to do the right thing.

Signed-off-by: Cyril Chemparathy <redacted>
Signed-off-by: Vitaly Andrianov <redacted>
Reviewed-by: Nicolas Pitre <redacted>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help