[PATCH] ARM: suspend: use flush range instead of flush all

On Wed, Sep 12, 2012 at 3:16 PM, Russell King - ARM Linux
[off-list ref] wrote:

On Wed, Sep 12, 2012 at 02:40:45PM +0530, Shilimkar, Santosh wrote:

quoted

On Wed, Sep 12, 2012 at 2:24 PM, Russell King - ARM Linux
[off-list ref] wrote:

quoted

On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote:

quoted

On Wed, Sep 12, 2012 at 12:48 PM, wzch [off-list ref] wrote:

quoted

 void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr)
 {
+       u32 *ptr_orig = ptr;
        *save_ptr = virt_to_phys(ptr);

        /* This must correspond to the LDM in cpu_resume() assembly */

@@ -26,7 +27,8 @@ void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr)

        cpu_do_suspend(ptr);

-       flush_cache_all();

Lorenzo's patch was limiting above flush to local cache (LOUs) instead
of dropping it completely.

Err, that is wrong.  Normally, when CPUs go into suspend, the L1 cache is
lost entirely.  This is the only flush which many CPUs see of the L1
cache.

So removing this flush _will_ break suspend to RAM on existing CPUs.

As mentioned, keeping that flush till inner shareability domain(L1) should be
enough. In fact if that part gets pushed down to the finisher() which any
way needs to take care of the cache maintenance, we can get rid of completely.

It is difficult to call the cache maintenance functions from assembly.
Why not have the generic code do the inner shareability flush, and then
leave the responsibility for any further cache maintenance caused by the
actions of the finisher to the finisher to deal with - as it is now.

That way we end up with more generic code, and don't go back to the
rediculous situation where we had everyone implementing this crap in
their own broken way time and time again in their platform code.

Fully agree with you.
Leaving the local cache flush should be better choice and that
is the additional bit Lorenzo's patch(yet to be posted) is doing on top
of the $subject patch. If the platform has special need like secure
cache maintenance, they can take care of that additionally in the
finisher.

Regards
Santosh