Thread (9 messages) flat view 9 messages, 4 authors, 2012-09-13

[PATCH] ARM: suspend: use flush range instead of flush all

From: Russell King - ARM Linux <hidden>
Date: 2012-09-12 08:57:15
Also in: lkml

On Wed, Sep 12, 2012 at 01:13:33PM +0530, Shilimkar, Santosh wrote:
On Wed, Sep 12, 2012 at 12:48 PM, wzch [off-list ref] wrote:
quoted
 void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr)
 {
+       u32 *ptr_orig = ptr;
        *save_ptr = virt_to_phys(ptr);

        /* This must correspond to the LDM in cpu_resume() assembly */
@@ -26,7 +27,8 @@ void __cpu_suspend_save(u32 *ptr, u32 ptrsz, u32 sp, u32 *save_ptr)

        cpu_do_suspend(ptr);

-       flush_cache_all();
Lorenzo's patch was limiting above flush to local cache (LOUs) instead
of dropping it completely.
Err, that is wrong.  Normally, when CPUs go into suspend, the L1 cache is
lost entirely.  This is the only flush which many CPUs see of the L1
cache.

So removing this flush _will_ break suspend to RAM on existing CPUs.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help