[PATCH 03/10] serial: atmel: add explict mach/gpio.h include

On 22:00 Thu 30 Aug     , Rob Herring wrote:

On 08/29/2012 06:37 PM, Russell King - ARM Linux wrote:

quoted

On Wed, Aug 29, 2012 at 05:31:29PM -0500, Rob Herring wrote:

quoted

From: Rob Herring <redacted>

In preparation to remove implicit inclusion of mach/gpio.h, add explicit
include of mach/gpio.h.

Definitely NAK.

What is in the Atmel mach/gpio.h has hardly anything to do with the
gpio subsystem (it's more a private gpio implementation).  It should
be renamed as such to make it clear (and so it doesn't trigger my
sanity filtering.)

Jean-Christophe, Does your gpio clean-up address this?

yes I've a patch series on my local tree that cleanup this

on at91 we do not need the include/mach/gpio.h

and I do plan to drop most of the stuff in it

Best Regards,
J.