Thread (26 messages) flat view 26 messages, 6 authors, 2012-09-04
STALE5085d

[PATCH 03/10] serial: atmel: add explict mach/gpio.h include

From: Rob Herring <hidden>
Date: 2012-08-31 03:00:28

On 08/29/2012 06:37 PM, Russell King - ARM Linux wrote:
On Wed, Aug 29, 2012 at 05:31:29PM -0500, Rob Herring wrote:
quoted
From: Rob Herring <redacted>

In preparation to remove implicit inclusion of mach/gpio.h, add explicit
include of mach/gpio.h.
Definitely NAK.

What is in the Atmel mach/gpio.h has hardly anything to do with the
gpio subsystem (it's more a private gpio implementation).  It should
be renamed as such to make it clear (and so it doesn't trigger my
sanity filtering.)
Jean-Christophe, Does your gpio clean-up address this?

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help