[PATCH] ARM: ep93xx: clockevent support

On 09/08/12 18:54, Yan Burman wrote:

On 8/7/12, Ryan Mallon [off-list ref] wrote:

quoted

On 07/08/12 21:21, Yan Burman wrote:

quoted

ARM: ep93xx: clockevent support
I have ported to 3.6-rc1 and slightly modified a previous patch for
clockevent support for the ep93xx.
The porting mainly consists of sched_clock support.
Tested on 9302 based board.
From: Ahmed Ammar <aammar <at> edge-techno.com>
Signed-off-by: Yan Burman <redacted>

Hi Yan, some comments below.

~Ryan

quoted

+	case CLOCK_EVT_MODE_ONESHOT:
+		tmode |= EP93XX_TIMER123_CONTROL_ENABLE;
+		__raw_writel(tmode, EP93XX_TIMER1_CONTROL);
+		break;
+
+	case CLOCK_EVT_MODE_SHUTDOWN:
+	case CLOCK_EVT_MODE_UNUSED:
+	case CLOCK_EVT_MODE_RESUME:
+		return;

These cases can be removed.

This case is something that is present in most (if not all) other architectures.
I don't mind removing it, but it will have to be replaced with:
default:
     ;

Since GCC produces warnings otherwise.

Oh, I missed the fact the switch was on an enum. You are correct, we
should keep the code consistent with other architectures, so this
can be left as is.

Other than that I am going to wait a while more for more comments if
somebody has them,
and post a new version with style fixes as well as switch to
drivers/clocksource/mmio.c usage.

Great, thanks,
~Ryan