Thread (6 messages) flat view 6 messages, 4 authors, 2012-08-09
STALE5130d

[PATCH] ARM: ep93xx: clockevent support

From: Yan Burman <hidden>
Date: 2012-08-09 08:54:40

On 8/7/12, Ryan Mallon [off-list ref] wrote:
On 07/08/12 21:21, Yan Burman wrote:
quoted
ARM: ep93xx: clockevent support
I have ported to 3.6-rc1 and slightly modified a previous patch for
clockevent support for the ep93xx.
The porting mainly consists of sched_clock support.
Tested on 9302 based board.
From: Ahmed Ammar <aammar <at> edge-techno.com>
Signed-off-by: Yan Burman <redacted>

Hi Yan, some comments below.

~Ryan
quoted
+	case CLOCK_EVT_MODE_ONESHOT:
+		tmode |= EP93XX_TIMER123_CONTROL_ENABLE;
+		__raw_writel(tmode, EP93XX_TIMER1_CONTROL);
+		break;
+
+	case CLOCK_EVT_MODE_SHUTDOWN:
+	case CLOCK_EVT_MODE_UNUSED:
+	case CLOCK_EVT_MODE_RESUME:
+		return;

These cases can be removed.
This case is something that is present in most (if not all) other architectures.
I don't mind removing it, but it will have to be replaced with:
default:
     ;

Since GCC produces warnings otherwise.

Other than that I am going to wait a while more for more comments if
somebody has them,
and post a new version with style fixes as well as switch to
drivers/clocksource/mmio.c usage.

Regards,
Yan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help