[PATCH 0/6] ARM: mxs: remove board files · Shawn Guo <hidden> · 2012-08-06
[PATCH 1/6] ARM: mxs: tx28: reset fec phy for device tree boot · Shawn Guo <hidden> · 2012-08-06
[PATCH 1/6] ARM: mxs: tx28: reset fec phy for device tree boot · Otavio Salvador <hidden> · 2012-08-06
[PATCH 1/6] ARM: mxs: tx28: reset fec phy for device tree boot · Shawn Guo <hidden> · 2012-08-07
[PATCH 1/6] ARM: mxs: tx28: reset fec phy for device tree boot · arnd@arndb.de (Arnd Bergmann) · 2012-08-07
[PATCH 1/6] ARM: mxs: tx28: reset fec phy for device tree boot · Shawn Guo <hidden> · 2012-08-08
[PATCH 2/6] ARM: mxs: use auxdata to pass flexcan_switch function hook · Shawn Guo <hidden> · 2012-08-06
[PATCH 3/6] ARM: mxs: remove board files · Shawn Guo <hidden> · 2012-08-06
[PATCH 4/6] ARM: mxs: remove non-DT core functions · Shawn Guo <hidden> · 2012-08-06
[PATCH 5/6] ARM: mxs: remove platform device codes · Shawn Guo <hidden> · 2012-08-06
[PATCH 6/6] ARM: mxs: remove iomux driver · Shawn Guo <hidden> · 2012-08-06
[PATCH 0/6] ARM: mxs: remove board files · arnd@arndb.de (Arnd Bergmann) · 2012-08-07

DORMANTno replies

Revision v1 of 5 in this series.

Revisions (5)

2012-08-06 v1 [diff vs current]
2012-08-06 v1 [diff vs current]
2012-08-07 v1 [diff vs current]
2012-08-07 v1 [diff vs current]
2012-08-08 v1 current

[PATCH 1/6] ARM: mxs: tx28: reset fec phy for device tree boot

From: Shawn Guo <hidden>
Date: 2012-08-08 14:41:51

On Tue, Aug 07, 2012 at 07:15:25PM +0000, Arnd Bergmann wrote:

quoted

+       /* Power up fec phy */
+       gpio_set_value(TX28_FEC_PHY_POWER, 1);
+       mdelay(26); /* 25ms according to data sheet */

26 ms is a long time for a delay. I think you should use msleep here.

I copied this from TX28 board file.  But I just changed it per your
comment.  Thanks.

-- 
Regards,
Shawn