Thread (99 messages) 99 messages, 9 authors, 2012-08-06

[PATCH 20/24] xen: update xen_add_to_physmap interface

From: Mukesh Rathor <hidden>
Date: 2012-08-01 18:20:13
Also in: lkml, xen-devel

On Wed, 1 Aug 2012 10:52:15 -0400
Konrad Rzeszutek Wilk [off-list ref] wrote:
On Thu, Jul 26, 2012 at 04:34:02PM +0100, Stefano Stabellini wrote:
quoted
Update struct xen_add_to_physmap to be in sync with Xen's version
of the structure.
The size field was introduced by:

changeset:   24164:707d27fe03e7
user:        Jean Guyader [off-list ref]
date:        Fri Nov 18 13:42:08 2011 +0000
summary:     mm: New XENMEM space, XENMAPSPACE_gmfn_range

According to the comment:

"This new field .size is located in the 16 bits padding
between .domid and .space in struct xen_add_to_physmap to stay
compatible with older versions."

This is not true on ARM where there is not padding, but it is valid
on X86, so introducing size is safe on X86 and it is going to fix
the interace for ARM.
Has this been checked actually for backwards compatibility? It sounds
like it should work just fine with Xen 4.0 right?

I believe this also helps Mukesh's patches, so CC-ing him here for
his Ack.
Yup, I already had that change in my tree.

thanks,
Mukesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help