[Xen-devel] [PATCH 06/24] xen: missing includes
From: Jan Beulich <hidden>
Date: 2012-07-27 06:57:27
Also in:
lkml, xen-devel
quoted hunk ↗ jump to hunk
quoted
quoted
On 26.07.12 at 17:33, Stefano Stabellini [off-list ref] wrote:--- a/include/xen/interface/xen.h +++ b/include/xen/interface/xen.h@@ -10,7 +10,10 @@ #define __XEN_PUBLIC_XEN_H__ #include <asm/xen/interface.h> +#include <linux/types.h> +#ifdef CONFIG_X86 #include <asm/pvclock-abi.h> +#endif
Rather than hacking around this, why not clean it up: asm/pvclock-abi.h clearly isn't intended to be included here (from the perspective of the origin of xen/interface/xen.h, at least), nor is linux/types.h. Or if it is really needed to deviate from the original header in this respect, then clearly the inclusion ought to not be arch specific or be moved to an arch specific header. Jan
/* * XEN "SYSTEM CALLS" (a.k.a. HYPERCALLS).