On Mon, Jul 02, 2012 at 12:49:37AM +0200, Marc Kleine-Budde wrote:

quoted

+	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+	if (IS_ERR(pinctrl))
+		return PTR_ERR(pinctrl);
+
 	if (pdev->dev.of_node) {
 		const u32 *clock_freq_p;

I'm on mx28 and trying to load the flexcan driver via DT, but
devm_pinctrl_get_select_default fails with -19.

You need to have pinctrl state setup in dts, some like:

http://article.gmane.org/gmane.linux.ports.arm.kernel/174148

What am I doing wrong? Will this fail with the same error on non DT
platforms?

No, it will not, because a dummy pinctrl state is provided by
calling pinctrl_provide_dummies() in mx28_soc_init().

-- 
Regards,
Shawn