[PATCH v2 0/2] Add D_CAN device tree data to AM335x-EVM

STALE5160d

8 messages, 5 authors, 2012-08-07 · open the first message on its own page

[PATCH v2 0/2] Add D_CAN device tree data to AM335x-EVM

From: AnilKumar Ch <hidden>
Date: 2012-07-25 12:23:30

Thid patch series adds device tree data to AM335x-EVM file and
adds pinmux settings required to configure two of the AM335x EVM
pins to D_CAN TX/RX pins.

Changes from v1:
	- These two patches separated from c_can DT support
	  patch series.

AnilKumar Ch (2):
  arm/dts: AM33XX: Add D_CAN device tree data
  arm/dts: AM33XX: Configure pinmuxs for D_CAN1 on AM335x-EVM

 arch/arm/boot/dts/am335x-evm.dts |   13 +++++++++++++
 arch/arm/boot/dts/am33xx.dtsi    |    5 +++++
 2 files changed, 18 insertions(+)

-- 
1.7.9.5

[PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

From: AnilKumar Ch <hidden>
Date: 2012-07-25 12:23:31

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

Signed-off-by: AnilKumar Ch <redacted>
---
 arch/arm/boot/dts/am33xx.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi

@@ -163,5 +163,10 @@
 			#size-cells = <0>;
 			ti,hwmods = "i2c3";
 		};
+
+		dcan1: d_can at 481D0000 {
+			compatible = "bosch,d_can";
+			ti,hwmods = "d_can1";
+		};
 	};
 };

-- 
1.7.9.5

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

From: Sergei Shtylyov <hidden>
Date: 2012-07-25 12:43:40

Hello.

On 25-07-2012 16:23, AnilKumar Ch wrote:

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

Signed-off-by: AnilKumar Ch <redacted>
---
  arch/arm/boot/dts/am33xx.dtsi |    5 +++++
  1 file changed, 5 insertions(+)

quoted hunk

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi

@@ -163,5 +163,10 @@
  			#size-cells = <0>;
  			ti,hwmods = "i2c3";
  		};
+
+		dcan1: d_can at 481D0000 {

    Address postfix in the node name and no "reg" property?

+			compatible = "bosch,d_can";
+			ti,hwmods = "d_can1";
+		};

WBR, Sergei

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

From: Daniel Mack <zonque@gmail.com>
Date: 2012-07-26 08:36:55

On 25.07.2012 14:43, Sergei Shtylyov wrote:

Hello.

On 25-07-2012 16:23, AnilKumar Ch wrote:

quoted

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

quoted

Signed-off-by: AnilKumar Ch <redacted>
---
  arch/arm/boot/dts/am33xx.dtsi |    5 +++++
  1 file changed, 5 insertions(+)

quoted

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi

@@ -163,5 +163,10 @@
  			#size-cells = <0>;
  			ti,hwmods = "i2c3";
  		};
+
+		dcan1: d_can at 481D0000 {

    Address postfix in the node name and no "reg" property?

This still works due to the hwmod mappings OMAP relies on. I would still
put it there, so the switch to real DT definitions will be less painful.


Daniel

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

From: Koen Kooi <hidden>
Date: 2012-07-26 08:46:33

Op 25 jul. 2012, om 14:23 heeft AnilKumar Ch [off-list ref] het volgende geschreven:

quoted hunk

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

Signed-off-by: AnilKumar Ch <redacted>
---
arch/arm/boot/dts/am33xx.dtsi |    5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi

@@ -163,5 +163,10 @@

			#size-cells = <0>;
			ti,hwmods = "i2c3";
		};
+
+		dcan1: d_can at 481D0000 {
+			compatible = "bosch,d_can";
+			ti,hwmods = "d_can1";
+		};
	};

I scanned the linux-networking mailinglist and l-o-ml, but I can't find the patchset that actually adds the d_can drivers, could you provide a link to that? I have 2 different CAN capes I'd like to test on beaglebone.

regards,

Koen

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

From: Sergei Shtylyov <hidden>
Date: 2012-07-26 13:04:41

Hello.

On 26-07-2012 12:36, Daniel Mack wrote:

quoted

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

quoted

Signed-off-by: AnilKumar Ch <redacted>
---
   arch/arm/boot/dts/am33xx.dtsi |    5 +++++
   1 file changed, 5 insertions(+)

quoted

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi

@@ -163,5 +163,10 @@
   			#size-cells = <0>;
   			ti,hwmods = "i2c3";
   		};
+
+		dcan1: d_can at 481D0000 {

     Address postfix in the node name and no "reg" property?

This still works due to the hwmod mappings OMAP relies on.

    I.e. the "reg" property is populated in runtime?

I would still
put it there, so the switch to real DT definitions will be less painful.

    How it helps anything?

Daniel

WBR, Sergei

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

From: Vaibhav Hiremath <hidden>
Date: 2012-08-03 06:28:41


On 7/25/2012 5:53 PM, AnilKumar Ch wrote:

quoted hunk

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

Signed-off-by: AnilKumar Ch <redacted>
---
 arch/arm/boot/dts/am33xx.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi

@@ -163,5 +163,10 @@
 			#size-cells = <0>;
 			ti,hwmods = "i2c3";
 		};
+
+		dcan1: d_can at 481D0000 {
+			compatible = "bosch,d_can";
+			ti,hwmods = "d_can1";
+		};

Anil,

Any reason why we are only specifying dcan1 instance? Shouldn't we
specify dcan0 as well here?

Thanks,
Vaibhav

 	};
 };

RE: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

From: AnilKumar, Chimata <hidden>
Date: 2012-08-07 11:40:40

Vaibhav,

Thanks for the review.

On Fri, Aug 03, 2012 at 11:58:41, Hiremath, Vaibhav wrote:


On 7/25/2012 5:53 PM, AnilKumar Ch wrote:

quoted

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

Signed-off-by: AnilKumar Ch <redacted>
---
 arch/arm/boot/dts/am33xx.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi

@@ -163,5 +163,10 @@
 			#size-cells = <0>;
 			ti,hwmods = "i2c3";
 		};
+
+		dcan1: d_can at 481D0000 {
+			compatible = "bosch,d_can";
+			ti,hwmods = "d_can1";
+		};

Anil,

Any reason why we are only specifying dcan1 instance? Shouldn't we
specify dcan0 as well here?

Yes, I agree dcan0 needs to add because SoC support two instances. I
have added d_can1 only because on AM335x-EVM d_can1 is available and
in other case AM335x-bone have two instances available. I will send next
version of these patches.

Regards
AnilKumar

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help