Thread (46 messages) 46 messages, 3 authors, 2012-08-21
STALE5054d

[PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

From: Mohammed, Afzal <hidden>
Date: 2012-06-28 12:44:30
Also in: linux-omap

Hi Tony,

On Thu, Jun 28, 2012 at 18:02:07, Tony Lindgren wrote:
* Mohammed, Afzal [off-list ref] [120628 02:36]:
quoted
diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c
index c8a9487..bbae674 100644
--- a/arch/arm/mach-omap2/gpmc-onenand.c
+++ b/arch/arm/mach-omap2/gpmc-onenand.c
@@ -364,6 +364,8 @@ static int omap2_onenand_setup_async(void __iomem *onenand_base)
        struct gpmc_timings t;
        int ret;

+       omap2_onenand_set_async_mode(onenand_base);
+
        t = omap2_onenand_calc_async_timings();

        ret = gpmc_set_async_mode(gpmc_onenand_data->cs, &t);
Yes that seems to do the trick, thanks! I can fold that into the
breaking patch when applying.

Also following needs to be removed from commit message,

"Ensuring sync read/write are disabled in onenand cannot
be expected to work properly unless GPMC is setup, this
has been removed."

With the above diff we are in effect disabling sync mode in
onenand before GPMC has been setup in the Kernel

If you want, I can sent a new series too.

Regards
Afzal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help