Freescale fec.c driver breakage

On Tuesday 05 June 2012 6:41:16 am Mark Brown wrote:

On Tue, Jun 05, 2012 at 11:24:29PM +1000, Greg Ungerer wrote:

quoted

Well, yeah, of course there are clocks involved. But you pretty much
hit the point here. 'ipg' and 'ahb' here are platform specific.

What should be happening for that is that the driver requests with some
generic name which is referenced to the IP (unfortunately these are
usually not documented for the public...) and then clkdev or some
platform specific code is used to map the names onto the underlying
clocks.

If 'ahb' isn't suitable how about 'bus', and for 'ipg' how about 'mclk'
or something?

Some of the newer Coldfire parts such as the m54455/m5441x do have software 
controllable clocks; but they keep it simple with one clock per fec, and 
names in the documentation like 'fec0, fec1' for the m54455 
and 'macnet0,macnet1' for the m5441x.